Introduce a product classifier #6680
Draft
+203
−49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8c88f36 to
082d72b
Compare
escattone
reviewed
May 27, 2025
There was a problem hiding this comment.
Overall, I like this approach. I'd suggest one refinement. I think we should only run the product re-classification when we know that the only reason the question was marked as spam was because of its irrelevance to its original product. In other words, it was a legitimate support request, but not relevant to its original product classification. The spam classification step can provide that extra information in its result without changing its current scope.
I created a PR based on your work here that shows what I'm thinking. I tested it using two examples that Emil provided and it worked great.
082d72b to
1d2ba71
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.